Don't create a COM weak reference if the object is an aggregated COMWrappers RCW. #61267
+218
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/tests/Interop/COM/ComWrappers/WeakReference/WeakReferenceTest.cs
Outdated
Show resolved
Hide resolved
jkoritzinsky
commented
Nov 5, 2021
jkoritzinsky
commented
Nov 5, 2021
src/tests/Interop/COM/ComWrappers/WeakReference/WeakReferenceTest.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Robinson <[email protected]>
AaronRobinsonMSFT
approved these changes
Nov 6, 2021
|
@jkoritzinsky Let's start the port to .NET 6 ASAP. |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1429642390 |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents us from trying to re-create a managed object that is a user-defined object deriving from an RCW type from a COM IWeakReference (which fails).
The included test crashes on main with an AV and passes with the changes in this PR.
Fixes microsoft/CsWinRT#1025